Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unnecessary access modifiers on interface methods. #563

Merged
merged 3 commits into from
Feb 4, 2020
Merged

chore: Remove unnecessary access modifiers on interface methods. #563

merged 3 commits into from
Feb 4, 2020

Conversation

ethanwood17
Copy link
Contributor

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the development branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Having access modifiers on interface methods is unnecessary, as all interface methods are public
  • Therefore, I've removed them to improve code readability.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Apr 10, 2019
@SendGridDX
Copy link
Collaborator

SendGridDX commented Apr 10, 2019 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ethanwood17
❌ Ethan

Ethan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ethanwood17
Copy link
Contributor Author

Looks like tests failed due to issue #561. PR #562 should resolve this.

@childish-sambino childish-sambino changed the title Remove unnecessary access modifiers on interface methods. chore: Remove unnecessary access modifiers on interface methods. Feb 4, 2020
@childish-sambino childish-sambino merged commit 1b2a55e into sendgrid:master Feb 4, 2020
@thinkingserious
Copy link
Contributor

Hello @ethanwood17,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethanwood17 @SendGridDX @thinkingserious @childish-sambino